fix(cam_hal): prevent SOI scan from (1) running on length<3 and (2) over-reading the last 2 bytes #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and (2) over-reading the last 2 bytes Changes: * Store SOI as a 3-byte array (0xFF D8 FF) and use sizeof() everywhere. * Early-exit when length < 3 to avoid over-reading * calculate end index correctly, to avoid over-reading
|
@turenkomv thanks for your patience. Sadly this bug can IMHO not cause a stack trashing, only cause wrong returns. |
6 tasks
RubenKelevra
force-pushed
the
fix_jpeg-soi-overread
branch
from
f412add to
711b572
Compare
6 tasks
|
Log changes moved to PR #765 to keep this PR small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x## Description
Changes:
Related
In the search for the cause of crashes reported by @turenkomv here: esphome/esphome#8832 (comment) I found this overread of a pointer, which can cause undefined behaviour.
Checklist
Before submitting a Pull Request, please ensure the following: